Update retry handler used by Pro Client #1238
Merged
+1,522
−409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atavism
changed the title
atavism
changed the title
|
@jigar-f I'm testing this now, but it would be great if you could start taking a look! |
|
@atavism I'll give it look tomorrow, thanks |
jigar-f
reviewed
Dec 3, 2024
* Fix user create api on android. * Fix desktop build issue.
jigar-f
reviewed
Dec 5, 2024
| final isLevelPro = userLevel != null && userLevel == 'pro'; | ||
| final isStatusPro = userStatus != null && userStatus == 'active'; | ||
| if (isLevelPro || isStatusPro) { | ||
| sessionModel.proUserNotifier.value = true; |
There was a problem hiding this comment.
We also need to make sure to set it to false.
jigar-f
approved these changes
Dec 5, 2024
jigar-f
reviewed
Dec 5, 2024
| @@ -109,44 +107,44 @@ func (app *App) IsProUserFast(uc common.UserConfig) (isPro bool, statusKnown boo | |||
| // It loops forever in 10 seconds interval until the user is fetched or | |||
| // created, as it's fundamental for the UI to work. | |||
| func (app *App) servePro(channel ws.UIChannel) error { | |||
| chFetch := make(chan bool) | |||
| ctx := context.Background() | |||
| go func() { | |||
There was a problem hiding this comment.
@atavism We were creating two users like in android, We don't need this anymore, Since we are creating user in afterStart
There was a problem hiding this comment.
Thanks for removing this!
Thanks, looks great to me! Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the retry handler for user creation, originally implemented for Android, to work across multiple platforms, including desktop